-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve migrate flow #1198
Improve migrate flow #1198
Conversation
534061c
to
08b83d4
Compare
internal/cli/install/helm/install.go
Outdated
@@ -77,7 +76,7 @@ func (c *Helm) Install(ctx context.Context, status *printer.StatusPrinter, opts | |||
} | |||
|
|||
if !upgrade { | |||
return nil, errors.New("upgrade aborted") | |||
return nil, nil |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM 🚀
@josefkarasek I saw only one glitch about flow, even we use |
I could not reproduce this. With Huseyin we agreed we'll monitor this in the immediate future. |
Description
Changes proposed in this pull request:
k8s-default-tools
are disabled/not boundinstall
internal command to perform Botkube installationkubex.LoadRestConfigWithMetaInformation()
and register--kubeconfig
flag, to get OOTB experience with finding current k8s contextconfigurationName
botkube install
is used for both installation and upgrading an existing Botkube instance.Testing
Create Botkube instance in your local env
Login and migrate
For testing that Actions can be migrated even when a bound plugin is not defined - rename a plugin in one of the pre-defined actions and migrate. The Action should be omitted and not included in the migration.
Related issue(s)
#1172